fix: clicking back doesn't re query search #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @aamirazad and the rest of your teammates on |
This was referenced Jun 29, 2024
This was referenced Jun 30, 2024
aamirazad
force-pushed
the
06-29-fix_clicking_back_doesn_t_re_query_search
branch
from
0c0f823 to
fe2129d
Compare
aamirazad
force-pushed
the
06-29-fix_clicking_back_doesn_t_re_query_search
branch
from
191301f to
e5a70b1
Compare
Merge activity
|
aamirazad
force-pushed
the
06-29-feat_show_a_fun_fact_while_pdf_is_loading
branch
from
a4acb5a to
4c72edd
Compare
Base automatically changed from
06-29-feat_show_a_fun_fact_while_pdf_is_loading
to
main
July 6, 2024 17:17
aamirazad
force-pushed
the
06-29-fix_clicking_back_doesn_t_re_query_search
branch
from
e5a70b1 to
344385a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes a bug where when you would exit a modal, it would serach for the query below the modal even though nothing changed.
What changed?
I use prevent default on the button to only make it go browser back, not rerender after clicking.
Why?
This gives a better user experience and less load on the server.